-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devel xsens rebased #19
Devel xsens rebased #19
Conversation
…nfig file is added
Since the code has been rebased, I would suggest we test it once before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove CMakeLists.txt.user
, I think it is generated by QTCreator
} | ||
|
||
// m_tick =std::chrono::duration_cast< std::chrono::milliseconds | ||
// >(std::chrono::system_clock::now().time_since_epoch()); m_tock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to use a time profiler you can use the one in walking-controllers
. Actually there are several utilities in walking-controllers that can be used in different scenarios (e.g. Time-profiler
, Utilities library ). Probably we should find a way (e.g. move them in an other repo) to expose these libraries. @traversaro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can either move them in a different repo, or start installing some of the code contained in walking-controllers as libraries (that may be convenenient if we eventually implement robotology/walking-controllers#30 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we have it, we may go for adding it to retargeting if we need to have it.
Let me know if you want to clean the history. Otherwise, I'll merge the PR. |
1c888ca
to
5ece81c
Compare
Done! Thank you. |
Merge! |
As we discussed yesterday, I open this PR to merge my working activities from my fork to our shared repo on devel branch.
I have cleaned also the codes, and updated the application and config files.